Skip to content

Comments

feat: 15379 update minimum version modal UI#15567

Merged
weitingsun merged 1 commit intomainfrom
feat/15379-update-minimum-version-workflow-to-increase-user-adoption
May 26, 2025
Merged

feat: 15379 update minimum version modal UI#15567
weitingsun merged 1 commit intomainfrom
feat/15379-update-minimum-version-workflow-to-increase-user-adoption

Conversation

@weitingsun
Copy link
Contributor

@weitingsun weitingsun commented May 22, 2025 •
edited
Loading

Description

Update updates needed UI on mobile:

  • Remove Remind me later secondary cta
  • Add X close button on top right of the screen, should have the same behavior of existing Remind me later
  • Add MetaMask name logo on top
  • Replace image and copy

Related issues

Fixes: #15379

Manual testing steps

  1. Run locally
  2. Go to the file "useMinimumVersions.tsx" and flip the boolean shouldTriggerUpdateFlow in useEffect to trigger the modal
  3. Refresh the app
  4. Should see the update modal pops up

Screenshots/Recordings

Before

Android beforeiOS before

After

Android afteriOS after

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Contributor

github-actions bot commented May 22, 2025 •
edited
Loading

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@weitingsun
Copy link
Contributor Author

weitingsun commented May 22, 2025

I have read the CLA Document and I hereby sign the CLA

@weitingsun weitingsun self-assigned this May 22, 2025
@weitingsun weitingsun added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label May 22, 2025
@github-project-automation github-project-automation bot moved this to Needs dev review in PR review queue May 22, 2025
@weitingsun weitingsun added No QA Needed Apply this label when your PR does not need any QA effort. Run Smoke E2E labels May 22, 2025
@github-actions

This comment was marked as duplicate.

Sign in to view
@weitingsun weitingsun added the team-mobile-platform Mobile Platform team label May 23, 2025
@weitingsun weitingsun force-pushed the feat/15379-update-minimum-version-workflow-to-increase-user-adoption branch 2 times, most recently from cb6f621 to fccbd5b Compare May 23, 2025 18:01
@github-actions

This comment was marked as duplicate.

Sign in to view
@weitingsun weitingsun force-pushed the feat/15379-update-minimum-version-workflow-to-increase-user-adoption branch from fccbd5b to b5c4f31 Compare May 23, 2025 18:54
@github-actions

This comment was marked as duplicate.

Sign in to view
sethkfman
sethkfman reviewed May 23, 2025
View reviewed changes
sethkfman
sethkfman approved these changes May 23, 2025
View reviewed changes
Copy link
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-project-automation github-project-automation bot moved this from Needs dev review to Review finalised - Ready to be merged in PR review queue May 23, 2025
@weitingsun weitingsun marked this pull request as ready for review May 24, 2025 02:23
@weitingsun weitingsun force-pushed the feat/15379-update-minimum-version-workflow-to-increase-user-adoption branch from b5c4f31 to 6958eec Compare May 26, 2025 16:26
@github-actions

This comment was marked as duplicate.

Sign in to view
@weitingsun weitingsun force-pushed the feat/15379-update-minimum-version-workflow-to-increase-user-adoption branch from 6958eec to 76bb5c8 Compare May 26, 2025 17:37
@github-actions
Copy link
Contributor

github-actions bot commented May 26, 2025 •
edited by metamaskbot
Loading

https://bitrise.io/ Bitrise

✅✅✅ pr_smoke_e2e_pipeline passed on Bitrise! ✅✅✅

Commit hash: 76bb5c8
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/58642458-126f-42f5-bbc3-10b44c7dcb29

Note

  • You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

@sonarqubecloud
Copy link

sonarqubecloud bot commented May 26, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@weitingsun weitingsun enabled auto-merge May 26, 2025 21:20
@weitingsun weitingsun added this pull request to the merge queue May 26, 2025
Merged via the queue into main with commit bba284a May 26, 2025
50 of 52 checks passed
@weitingsun weitingsun deleted the feat/15379-update-minimum-version-workflow-to-increase-user-adoption branch May 26, 2025 21:43
@github-actions github-actions bot locked and limited conversation to collaborators May 26, 2025
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label May 26, 2025
@metamaskbot metamaskbot added the release-7.48.0 Issue or pull request that will be included in release 7.48.0 label May 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sethkfman sethkfman sethkfman approved these changes

Assignees

@weitingsun weitingsun

Labels

No QA Needed Apply this label when your PR does not need any QA effort. release-7.48.0 Issue or pull request that will be included in release 7.48.0 team-mobile-platform Mobile Platform team

Projects

PR review queue
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update minimum version workflow to increase user adoption.

3 participants

@weitingsun @sethkfman @metamaskbot